Failed removing blobs from [...]/microcode/amd.c with deblob-5.4

[Alexandre Oliva]

Hello, Denis,

On Dec  2, 2019, "Denis 'GNUtoo' Carikli" <GNUtoo at cyberdimension.org> wrote:

>> File "/usr/lib/python3.8/sre_parse.py", line 426, in _escape
>> raise source.error("bad escape %s" % escape, len(escape))
>> re.error: bad escape \e at position 270802

Thanks for the report.

It looks like python 3.8 tightened the regexp parser a bit.
I found a stray \e in a blobname that's been there since 2.6.38-libre.
Is this patch enough to get you going?


Failing that, you can always set PYTHON to some older version of python
when running deblob-main, so that that version is used instead, or to
false, in which case deblob-check as started by deblob-main will fall
back to ${AWK-gawk}, to ${PERL}, or even to ${SED-sed}.


Index: deblob-check
===================================================================
--- deblob-check	(revision 17051)
+++ deblob-check	(working copy)
@@ -1,6 +1,6 @@
 #! /bin/sh
 
-# deblob-check version 2019-11-17
+# deblob-check version 2019-12-02
 # Inspired in gNewSense's find-firmware script.
 # Written by Alexandre Oliva <lxoliva at fsfla.org>
 
@@ -2715,7 +2715,7 @@
     blobname '%s%04x%s["][,][ ]["]fw_sst_["][,][ 	\n]*sst_drv_ctx->pci_id[,][ ]["]\.bin' drivers/staging/intel_sst/intel_sst_common.h
     accept '[ ]*[*][ ]*0[ ]1[ ]2[ ]3[ ]4[ ]5[ ]6[ ]7[ ]8[ ]9[ ]0[ ]1[ ]2[ ]3[ ]4[ ]5[ ]6[ ]7[ ]8[ ]9[ ]0[ ]1[ ]2[ ]3[ ]4[ ]5[ ]6[ ]7[ ]8[ ]9[ ]0[ ]1' 'arch/x86/crypto/aesni-intel_asm\.S\|net/l2tp/l2tp_ip6\.c'
     defsnc 'static[ ]struct[ ]aead_testvec[ ]\(aes_gcm_rfc4106\)_\(enc\|dec\)_tv_template\[\][ ]=' 'crypto/testmgr.h'
-    blobname '\(sep[/]\)\?\extapp\.image\.bin' drivers/staging/sep/sep_driver.c
+    blobname '\(sep[/]\)\?extapp\.image\.bin' drivers/staging/sep/sep_driver.c
     blobname 'radeon[/]\(BARTS\|BTC\|TURKS\|CAICOS\|%s\)_\(pfp\|rlc\|[mc][ec]\)\.bin' 'drivers/gpu/drm/radeon/[ns]i\.c'
     defsnc 'static[ ]const[ ]u32[ ]\(barts\|turks\|caicos\)_io_mc_regs\[BTC_IO_MC_REGS_SIZE\]\[2\][ ]=' drivers/gpu/drm/radeon/ni.c
     defsnc 'static[ ]int[ ]types\[0x80\][ ]=' drivers/gpu/drm/nouveau/nv50_vram.c


-- 
Alexandre Oliva, freedom fighter   he/him   https://FSFLA.org/blogs/lxo
Free Software Evangelist           Stallman was right, but he's left :(
GNU Toolchain Engineer    FSMatrix: It was he who freed the first of us
FSF & FSFLA board member                The Savior shall return (true);